Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dashboard): Copy dashboard with duplicating charts 500 error #17707

Merged
merged 2 commits into from
Dec 9, 2021
Merged

fix(Dashboard): Copy dashboard with duplicating charts 500 error #17707

merged 2 commits into from
Dec 9, 2021

Conversation

geido
Copy link
Member

@geido geido commented Dec 9, 2021 •
edited
Loading

SUMMARY

Fixes an issue introduced by PR #17570 that was causing a 500 error in the backend when copying a dashboard with the "also copy (duplicate) charts" option.

TESTING INSTRUCTIONS

  1. Open a Dashboard
  2. Save the dashboard as a new one and tick "also copy (duplicate) charts"
  3. Observe the behavior

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

rusackas commented Dec 9, 2021

Kicking myself now... I looked at that line, and wondered about it, but I was trying not to rock the boat.

@rusackas
Copy link
Member

rusackas commented Dec 9, 2021

Thanks for the quick turnaround fix.

@rusackas rusackas added the v1.4 label Dec 9, 2021
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #17707 (b4775cc) into master (12bd1fc) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17707      +/-   ##
==========================================
- Coverage   67.98%   67.94%   -0.04%     
==========================================
  Files        1653     1653              
  Lines       66294    66375      +81     
  Branches     7107     7120      +13     
==========================================
+ Hits        45067    45097      +30     
- Misses      19338    19381      +43     
- Partials     1889     1897       +8
Flag Coverage Δ
javascript 56.25% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/dashboard/actions/dashboardState.js 35.79% <100.00%> (+0.45%) ⬆️
...nd/src/explore/components/DataTablesPane/index.tsx 76.92% <0.00%> (-0.75%) ⬇️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 21.34% <0.00%> (-0.50%) ⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx 38.53% <0.00%> (-0.36%) ⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 67.15% <0.00%> (-0.26%) ⬇️
superset-frontend/src/components/Select/Select.tsx 86.33% <0.00%> (ø)
...uperset-frontend/src/utils/getClientErrorObject.ts 71.87% <0.00%> (ø)
...src/dashboard/components/PropertiesModal/index.jsx
...src/dashboard/components/PropertiesModal/index.tsx 66.87% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12bd1fc...b4775cc. Read the comment docs.

@rusackas rusackas merged commit dad8c20 into apache:master Dec 9, 2021
eschutho pushed a commit that referenced this pull request Dec 11, 2021
@geido @eschutho
fix(Dashboard): Copy dashboard with duplicating charts 500 error (#17707
4c00bd4 
)

* Fix copy dashboard with charts

* Fix Cypress test
@serenajiang serenajiang mentioned this pull request Dec 15, 2021
Closed
9 tasks
eschutho pushed a commit that referenced this pull request Jan 27, 2022
@geido @eschutho
fix(Dashboard): Copy dashboard with duplicating charts 500 error (#17707
dbe43b8 
)

* Fix copy dashboard with charts

* Fix Cypress test
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@pkdotson pkdotson Awaiting requested review from pkdotson

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geido @rusackas @mistercrunch